[1.0] account management API questions

[connectdotz]

First of all, it is great to see account management API made it to web3, I think it will go a long way to reduce friction for dapp development.

A few questions to make sure I understand the idea behind the design:

1. Is there any particular reason the current accounts implementation does not support HD wallet (BIP32/BIP39) for account creation?
2. the current Wallet.save/Wallet.load is hard-coded with localStorage, will it make sense to allow customization?
3. while there is a clear extension point for provider, it didn't seem to be one for accounts. Most of the wallets out there used provider interface to inject its own accounts. It's a necessary evil before, but now with the modular accounts API, I wonder would it make sense to split extension points and allow accounts to be customized independent of the provider? (better for composition and less monolithic)

[frozeman]

1. we were planning on doing that, but it is more work. I would be happy for contributions on that side.
2. load save is only available in the browser, and you can easily encrypt yourself and choose what ever storage you like, the API is not restricting that. Load/save isa convenient function.
3. Not sure if i understand right, but there is a separate web3-eth-accounts package, if you want it network ID it can't sign, which if not give, will be automatically fetched from the node.

[jellegerbrandy]

Hello @frozeman , I may be interested in working on HD Wallet support.

It could be built on bitcore-lib (for the HD wallet) and bitcore-mnemonic (for the BIP39 seedphrase)

Not sure what your ideas would on how to integrate this stuff. It could either replace the address generation code of the wallet, i.e. to have wallet.create(numberOfAccounts, mnemonic) take an (optional) mnemonic argument that replaces the current entropy argument), or it cold be a new kind of object, or an option for wallet creation.

[netpi]

@jellegerbrandy @frozeman
This PR can solve this problem #1755

[nivida]

@jellegerbrandy Feel free to submitt a PR with a TransactionSigner object. We could add the possibility to pass a string like hd-wallet instead of an object which will load the HDWallet transaction signer.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions