fix!: remove websocket support #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when you try to use `@web3-storage/access` in a new next.js repository you get errors like this: ``` Import trace for requested module: ./node_modules/ipfs-utils/src/http/fetch.js ./node_modules/@web3-storage/upload-client/src/store.js ./node_modules/@web3-storage/upload-client/src/index.js ./node_modules/@web3-storage/w3up-client/src/client.js ./node_modules/@web3-storage/w3up-client/src/index.node.js ./app/utils/utils.ts ./app/page.tsx ./node_modules/ws/lib/buffer-util.js Module not found: Can't resolve 'bufferutil' in '/Users/travis/dev/pl/sample-w3/node_modules/ws/lib' Import trace for requested module: ./node_modules/ws/lib/buffer-util.js ./node_modules/ws/lib/websocket.js ./node_modules/ws/index.js ./node_modules/isomorphic-ws/node.js ./node_modules/@web3-storage/access/src/utils/ws.js ./node_modules/@web3-storage/access/src/agent-use-cases.js ./node_modules/@web3-storage/access/src/agent.js ./node_modules/@web3-storage/w3up-client/src/index.node.js ./app/utils/utils.ts ./app/page.tsx ./node_modules/ws/lib/validation.js Module not found: Can't resolve 'utf-8-validate' in '/Users/travis/dev/pl/sample-w3/node_modules/ws/lib' Import trace for requested module: ./node_modules/ws/lib/validation.js ./node_modules/ws/lib/receiver.js ./node_modules/ws/index.js ./node_modules/isomorphic-ws/node.js ./node_modules/@web3-storage/access/src/utils/ws.js ./node_modules/@web3-storage/access/src/agent-use-cases.js ./node_modules/@web3-storage/access/src/agent.js ./node_modules/@web3-storage/w3up-client/src/index.node.js ./app/utils/utils.ts ./app/page.tsx ``` Which looks like the same thing as netlify/netlify-lambda#179 and shows up a few other times in similar repos. While we could instruct our users to add some build configuration to go away, we don't use websockets in production in any of our flows and imho we should just remove this dependency. The easiest way to do this is to remove the cli as well, and since we don't use that anywhere that also seems like a good idea.
this is wonderful
alanshaw
approved these changes
Oct 10, 2023
travis
added a commit
that referenced
this pull request
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- ## [16.0.0](access-v15.3.0...access-v16.0.0) (2023-10-10) ### ⚠ BREAKING CHANGES * remove websocket support ([#966](#966)) ### Bug Fixes * remove websocket support ([#966](#966)) ([77bf7ea](77bf7ea)) * upgrade to latest ts ([#962](#962)) ([711e3f7](711e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you try to use
@web3-storage/accessin a new next.js repository you get errors like this:Which looks like the same thing as netlify/netlify-lambda#179 and shows up a few other times in similar repos.
While we could instruct our users to add some build configuration to go away, we don't use websockets in production in any of our flows and imho we should just remove this dependency. The easiest way to do this is to remove the cli as well, and since we don't use that anywhere that also seems like a good idea.