fix: make login idempotent #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
approved these changes
Nov 16, 2023
alanshaw
approved these changes
Nov 16, 2023
Gozala
added a commit
that referenced
this pull request
Nov 16, 2023
🤖 I have created a release *beep* *boop* --- ## [11.0.1](w3up-client-v11.0.0...w3up-client-v11.0.1) (2023-11-16) ### Bug Fixes * issue where typedoc docs would only show full docs for w3up-client ([#1141](#1141)) ([0b8d3f3](0b8d3f3)) * make login idempotent ([#1149](#1149)) ([c1df8d8](c1df8d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
olizilla
added a commit
to storacha/w3cli
that referenced
this pull request
Nov 22, 2023
landing storacha/w3up#1149 in w3cli split out createSpace to it's own helper function so tests can opt in to loginAndCreateSpace when they want the do it all in one convinence. logging in repeatedly isn't what we are typically testing. Calling the login helper repeatedly fails currently. I'll add a test and fix for that issue in a separate PR. License: MIT --------- Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging with the same account several times creates and stores redundant proofs and then sends them over during invocations.
Changes here avoid this redundancy by returning an account using existing proofs if you already happen to have them, essentially making login idempotent.