Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines random based on environment #568

Closed
jasverix opened this issue May 10, 2024 · 2 comments · Fixed by #574
Closed

Newlines random based on environment #568

jasverix opened this issue May 10, 2024 · 2 comments · Fixed by #574
Assignees
Labels
Milestone

Comments

@jasverix
Copy link

Version(s) affected

4.x

Description

When encoding or decoding RSA keys, the KeyConverter uses the PHP_EOL constant to add newlines. On Linux machines it works nice, but in other environments, it becomes "\r\n" which destroys the keys.

How to reproduce

Try to load a valid key on a Windows machine.

Possible Solution

Replace PHP_EOL with "\n".

Additional Context

No response

@Spomky Spomky self-assigned this Jun 14, 2024
@Spomky Spomky added the bug label Jun 14, 2024
@Spomky Spomky added this to the 3.5.0 milestone Jun 14, 2024
@Spomky Spomky linked a pull request Jun 16, 2024 that will close this issue
5 tasks
@Spomky
Copy link
Member

Spomky commented Jun 24, 2024

Fixed and tagged 3.4.4.

@Spomky Spomky closed this as completed Jun 24, 2024
@Spomky Spomky modified the milestones: 3.5.0, 3.4.4 Jul 1, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants