From b49f9c3451b64a39ece5708cff41a3f497b825ed Mon Sep 17 00:00:00 2001 From: Greg Bulmash Date: Sat, 13 Apr 2013 12:14:27 -0700 Subject: [PATCH 1/5] TTWF Select Option Collection - ver 1 Testing first paragraph of musts in 2.8.2.3 --- common/common-HTMLOptionsCollection.html | 75 ++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 common/common-HTMLOptionsCollection.html diff --git a/common/common-HTMLOptionsCollection.html b/common/common-HTMLOptionsCollection.html new file mode 100644 index 00000000000000..31b5ef7b1aa5af --- /dev/null +++ b/common/common-HTMLOptionsCollection.html @@ -0,0 +1,75 @@ + + + + + + HTMLOptionsCollection 2.8.3.2 + + + +
+ + + \ No newline at end of file From 3ec2558340f41b0cbd7da7677f4ec35ad94ef56a Mon Sep 17 00:00:00 2001 From: Greg Bulmash Date: Sat, 13 Apr 2013 12:18:12 -0700 Subject: [PATCH 2/5] Fixing Test 7 on HTMLOptionsCollection Changed value to null from undefined. --- common/common-HTMLOptionsCollection.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/common-HTMLOptionsCollection.html b/common/common-HTMLOptionsCollection.html index 31b5ef7b1aa5af..90ba6d67220c51 100644 --- a/common/common-HTMLOptionsCollection.html +++ b/common/common-HTMLOptionsCollection.html @@ -63,8 +63,8 @@ selly.length = 4; test(function () { - assert_equals(selly[6], undefined); - }, "Setting a length lower than the old length trims nodes from the end (checking that previously set node is now undefined)"); + assert_equals(selly[6], null); + }, "Setting a length lower than the old length trims nodes from the end (checking that previously set node is now null)"); test(function () { var newdiff = midval - selly.length; From 3132f9d3ab4a4e0d69154d312e71c7777cf09bb4 Mon Sep 17 00:00:00 2001 From: Greg Bulmash Date: Sat, 13 Apr 2013 13:41:32 -0700 Subject: [PATCH 3/5] Updates per Ms2ger comments Removed mutation events (split out into other file with async on mutation observers?) and made all other indicated fixes. --- .../common-HTMLOptionsCollection-part2.html | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 common/common-HTMLOptionsCollection-part2.html diff --git a/common/common-HTMLOptionsCollection-part2.html b/common/common-HTMLOptionsCollection-part2.html new file mode 100644 index 00000000000000..62d9f48329efca --- /dev/null +++ b/common/common-HTMLOptionsCollection-part2.html @@ -0,0 +1,24 @@ + + + + + + HTMLOptionsCollection 2.8.3.2 + + + +
+ + + \ No newline at end of file From a57f1ffcdac4919680057a6667ae64e24bf8706e Mon Sep 17 00:00:00 2001 From: Greg Bulmash Date: Sat, 13 Apr 2013 15:44:11 -0700 Subject: [PATCH 4/5] commit OptionsCollection.namedItem() tests Tests the namedItem() method on an HTMLOptionsCollection for correct return type/value on single match, no match, and multiple match cases. --- ...ommon-HTMLOptionsCollection-namedItem.html | 82 +++++++++++++++++++ .../common-HTMLOptionsCollection-part2.html | 24 ------ common/common-HTMLOptionsCollection.html | 40 +++------ 3 files changed, 94 insertions(+), 52 deletions(-) create mode 100644 common/common-HTMLOptionsCollection-namedItem.html delete mode 100644 common/common-HTMLOptionsCollection-part2.html diff --git a/common/common-HTMLOptionsCollection-namedItem.html b/common/common-HTMLOptionsCollection-namedItem.html new file mode 100644 index 00000000000000..3081b047daf79f --- /dev/null +++ b/common/common-HTMLOptionsCollection-namedItem.html @@ -0,0 +1,82 @@ + + + + + + HTMLOptionsCollection 2.8.3.2 + + + +
+ + + + + \ No newline at end of file diff --git a/common/common-HTMLOptionsCollection-part2.html b/common/common-HTMLOptionsCollection-part2.html deleted file mode 100644 index 62d9f48329efca..00000000000000 --- a/common/common-HTMLOptionsCollection-part2.html +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - HTMLOptionsCollection 2.8.3.2 - - - -
- - - \ No newline at end of file diff --git a/common/common-HTMLOptionsCollection.html b/common/common-HTMLOptionsCollection.html index 90ba6d67220c51..3e4fec4687905a 100644 --- a/common/common-HTMLOptionsCollection.html +++ b/common/common-HTMLOptionsCollection.html @@ -1,11 +1,11 @@  - + HTMLOptionsCollection 2.8.3.2 - +
\ No newline at end of file From 67c3f6860d0f6bf51c5fc22c301e26358ac2b1b4 Mon Sep 17 00:00:00 2001 From: Greg Bulmash Date: Wed, 24 Apr 2013 10:04:36 -0700 Subject: [PATCH 5/5] Moving to appropriate directory Moved from common/ to semantics/forms/the-select-element/ per feedback from tobie. Tests should now satisfy ms2ger's code quality suggestions and tobie's placement suggestions. --- .../common-HTMLOptionsCollection-namedItem.html | 0 .../forms/the-select-element}/common-HTMLOptionsCollection.html | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename {common => html/semantics/forms/the-select-element}/common-HTMLOptionsCollection-namedItem.html (100%) rename {common => html/semantics/forms/the-select-element}/common-HTMLOptionsCollection.html (100%) diff --git a/common/common-HTMLOptionsCollection-namedItem.html b/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem.html similarity index 100% rename from common/common-HTMLOptionsCollection-namedItem.html rename to html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem.html diff --git a/common/common-HTMLOptionsCollection.html b/html/semantics/forms/the-select-element/common-HTMLOptionsCollection.html similarity index 100% rename from common/common-HTMLOptionsCollection.html rename to html/semantics/forms/the-select-element/common-HTMLOptionsCollection.html