You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
href has a different codepath for URL objects vs <a>.
If you want to use JSON you need to use a list, as object order is not defined and we do not want indeterminate results.
Per specification # is escaped for passwords.
I recommend testing the delimiters. All the things where the normal parser would branch. E.g. when setting pathname, you want to test things like ../, ..?x, ..#x, x#, etc. (Now I take a closer look I see you've done some of that already for other properties, great.)
It would also be good to test unknown schemes here I guess. As per mailing list discussion the way they work needs to change and that will impact these algorithms. Although maybe you want to wait until we have an actual plan in place.
tl;dr: http://intertwingly.net/projects/pegurl/url-setters.html
Longer version: I don't notice any URL setters tests in http://w3c.github.io/test-results/url/all.html
I've been developing some as a part of my reference implementation work: https://github.com/rubys/url/blob/peg.js/reference-implementation/test/urlsettest.yml
I believe that some form of this belongs in web-platform-tests.
I'm interested in any and all feedback, including but not limited to:
@annevk @sideshowbarker @jgraham
The text was updated successfully, but these errors were encountered: