From 6adfcd0f53f3a5750567bb82a105f6bdedaa5899 Mon Sep 17 00:00:00 2001 From: Adam Rice Date: Thu, 2 Mar 2023 23:14:58 -0800 Subject: [PATCH] Revert "Implement CSSTransitionDiscrete which enables transitions on discrete properties." This reverts commit 367c58094d184ff90ef132789985bd4fc53c721a. Reason for revert: Causing failures in blink-web-tests on many bots, for example: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/127213/overview Original change's description: > Implement CSSTransitionDiscrete which enables transitions on discrete properties. > > This feature enables transitioning discrete properties. > > This is based on the resolved CSSWG issue: > - Transition discrete properties: https://github.com/w3c/csswg-drafts/issues/4441 > > You can test display transitions with this CL on: > https://output.jsbin.com/buquher/quiet > > Original patch: http://crrev.com/c/4182089 > > Bug: 1399631, 1413556 > Change-Id: Icf5364b970233186794fa9faaa016e0e6542ec2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219315 > Reviewed-by: Robert Flack > Commit-Queue: Joey Arhar > Cr-Commit-Position: refs/heads/main@{#1112645} Bug: 1399631, 1413556 Change-Id: I45cbf126b16402a88c7105d8204b342a79ded3d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4305045 Commit-Queue: Adam Rice Bot-Commit: Rubber Stamper Owners-Override: Adam Rice Cr-Commit-Position: refs/heads/main@{#1112668} --- .../all-with-discrete.tentative.html | 51 - .../discrete-no-interpolation.tentative.html | 911 ------------------ .../display-none-no-animations.html | 28 - .../animation/offset-interpolation.html | 12 +- css/support/interpolation-testcommon.js | 2 +- 5 files changed, 7 insertions(+), 997 deletions(-) delete mode 100644 css/css-transitions/all-with-discrete.tentative.html delete mode 100644 css/css-transitions/discrete-no-interpolation.tentative.html delete mode 100644 css/css-transitions/display-none-no-animations.html diff --git a/css/css-transitions/all-with-discrete.tentative.html b/css/css-transitions/all-with-discrete.tentative.html deleted file mode 100644 index f12c14e4c55285..00000000000000 --- a/css/css-transitions/all-with-discrete.tentative.html +++ /dev/null @@ -1,51 +0,0 @@ - - - - - - -
hello
-
hello
- - - - diff --git a/css/css-transitions/discrete-no-interpolation.tentative.html b/css/css-transitions/discrete-no-interpolation.tentative.html deleted file mode 100644 index 1dcb95581d99b9..00000000000000 --- a/css/css-transitions/discrete-no-interpolation.tentative.html +++ /dev/null @@ -1,911 +0,0 @@ - - - - - - - - - - diff --git a/css/css-transitions/display-none-no-animations.html b/css/css-transitions/display-none-no-animations.html deleted file mode 100644 index 32535baf9c7b1a..00000000000000 --- a/css/css-transitions/display-none-no-animations.html +++ /dev/null @@ -1,28 +0,0 @@ - - - - - -
target
- - - diff --git a/css/motion/animation/offset-interpolation.html b/css/motion/animation/offset-interpolation.html index 9c3747185dc830..2ee011bd77a975 100644 --- a/css/motion/animation/offset-interpolation.html +++ b/css/motion/animation/offset-interpolation.html @@ -15,9 +15,9 @@ to: 'path("M0 300H 700 Z") 600px 900deg', method: 'CSS Transitions', }, [ - {at: -0.3, expect: 'path("M0 200H 700") 470px 770deg'}, - {at: 0, expect: 'path("M0 200H 700") 500px 800deg'}, - {at: 0.3, expect: 'path("M0 200H 700") 530px 830deg'}, + {at: -0.3, expect: 'path("M0 300H 700 Z") 470px 770deg'}, + {at: 0, expect: 'path("M0 300H 700 Z") 500px 800deg'}, + {at: 0.3, expect: 'path("M0 300H 700 Z") 530px 830deg'}, {at: 0.6, expect: 'path("M0 300H 700 Z") 560px 860deg'}, {at: 1, expect: 'path("M0 300H 700 Z") 600px 900deg'}, {at: 1.5, expect: 'path("M0 300H 700 Z") 650px 950deg'}, @@ -29,9 +29,9 @@ to: 'path("M0 0H 300") 600px 0deg', method: 'CSS Transitions', }, [ - {at: -0.3, expect: 'path("M0 0H 170") 470px auto 0deg'}, - {at: 0, expect: 'path("M0 0H 200") 500px auto 0deg'}, - {at: 0.3, expect: 'path("M0 0H 230") 530px auto 0deg'}, + {at: -0.3, expect: 'path("M0 0H 170") 470px 0deg'}, + {at: 0, expect: 'path("M0 0H 200") 500px 0deg'}, + {at: 0.3, expect: 'path("M0 0H 230") 530px 0deg'}, {at: 0.6, expect: 'path("M0 0H 260") 560px 0deg'}, {at: 1, expect: 'path("M0 0H 300") 600px 0deg'}, {at: 1.5, expect: 'path("M0 0H 350") 650px 0deg'}, diff --git a/css/support/interpolation-testcommon.js b/css/support/interpolation-testcommon.js index 283a2d8aaba888..aa8239ae928654 100644 --- a/css/support/interpolation-testcommon.js +++ b/css/support/interpolation-testcommon.js @@ -56,7 +56,7 @@ target.style.setProperty(property, isNeutralKeyframe(from) ? '' : from); }, nonInterpolationExpectations: function(from, to) { - return expectFlip(from, to, 0.5); + return expectFlip(from, to, -Infinity); }, notAnimatableExpectations: function(from, to, underlying) { return expectFlip(from, to, -Infinity);