Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some interop-2022-cascade tests cover too many things #74

Closed
nt1m opened this issue May 5, 2022 · 6 comments · Fixed by web-platform-tests/wpt#34081
Closed

Some interop-2022-cascade tests cover too many things #74

nt1m opened this issue May 5, 2022 · 6 comments · Fixed by web-platform-tests/wpt#34081
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nt1m
Copy link
Member

nt1m commented May 5, 2022

@gsnedders
Copy link
Member

see also #5

I think we basically just want to use assert_implements_optional for these?

@jgraham jgraham added the test-change-proposal Proposal to add or remove tests for an interop area label May 9, 2022
@foolip
Copy link
Member

foolip commented May 12, 2022

@xiaochengh do you think these tests can be split (perhaps using variants) or use assert_implements_optional to avoid the hard dependency on these features?

@foolip
Copy link
Member

foolip commented May 12, 2022

Discussed in #77. General preference is that we split the tests if at all possible. Using assert_implements_optional would raise the question of what features are optional? Every other spec?

@xiaochengh
Copy link

Is there a list of tests we'd like to split, and a guideline how to split them?

@nt1m
Copy link
Member Author

nt1m commented May 16, 2022

@xiaochengh See the first comment, essentially css/css-cascade/layer-statement-before-import.html and css/css-cascade/layer-cssom-order-reverse.html

@foolip
Copy link
Member

foolip commented May 18, 2022

The tests were split in web-platform-tests/wpt#34081. Thanks @xiaochengh!

@foolip foolip reopened this May 18, 2022
@foolip foolip closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants