Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test change proposal for pointer events #628

Closed
nairnandu opened this issue Feb 1, 2024 · 11 comments
Closed

Test change proposal for pointer events #628

nairnandu opened this issue Feb 1, 2024 · 11 comments
Labels
focus area: Pointer and Mouse Events test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nairnandu
Copy link
Contributor

Test List

  1. coalesced_events_attributes_under_load.https.html?mouse
  2. coalesced_events_attributes.html?mouse
  3. idlharness.window.html
  4. mouse-pointer-boundary-events-for-shadowdom.html
  5. pointerevent_after_target_appended.html?mouse
  6. pointerevent_attributes_hoverable_rightbutton.html?mouse
  7. pointerevent_auxclick_is_a_pointerevent.html?mouse
  8. pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html
  9. pointerevent_capture_suppressing_mouse.html
  10. pointerevent_click_during_capture.html
  11. pointerevent_click_is_a_pointerevent_multiple_clicks.html?mouse
  12. pointerevent_click_is_a_pointerevent.html?mouse
  13. pointerevent_constructor.html
  14. pointerevent_contextmenu_is_a_pointerevent.html?mouse
  15. pointerevent_fractional_coordinates.html?mouse
  16. pointerevent_mouse_capture_change_hover.html
  17. pointerevent_mouse_pointercapture_inactivate_pointer.html
  18. pointerevent_pointermove_on_chorded_mouse_button.html
  19. pointerevent_pointerout_no_pointer_movement.html
  20. pointerevent_releasepointercapture_events_to_original_target.html?mouse
  21. pointerevent_sequence_at_implicit_release_on_click.html?mouse
  22. pointerevent_touch-action-keyboard.html
  23. predicted_events_attributes.html?mouse
  24. synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html?buttonType=LEFT&button=0&buttons=1
  25. synthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html?buttonType=MIDDLE&button=1&buttons=4

Rationale

As part of the carryover evaluation - #472 a new set of tests were proposed to be added. This was not reviewed during the carryover discussion. Raising it as a test change proposal.

@nairnandu nairnandu added the test-change-proposal Proposal to add or remove tests for an interop area label Feb 1, 2024
@nairnandu nairnandu changed the title Proposal for pointer events Test change proposal for pointer events Feb 1, 2024
@nairnandu
Copy link
Contributor Author

@jgraham @nt1m could you review these changes for Gecko and WebKit?

@jgraham
Copy link
Contributor

jgraham commented Feb 7, 2024

pointerevent_attributes_hoverable_rightbutton.html has been merged into pointerevent_attributes.html, so is already in the focus area.

Per @smaug---- pointerevent_click_during_capture.html is likely not correct, given that w3c/pointerevents#356 was fixed after the test was written. However we should fix the test and align implementations.

Generally we think these tests will likely require some work to correctly match the latest specs, but that adding them to the focus area makes sense since this is an area where implementation differences are regularly causing real world difficulties for users and web authors.

@nt1m
Copy link
Member

nt1m commented Feb 12, 2024

cc @aprotyas Here's a link to assess these tests: https://wpt.fyi/results/pointerevents?label=master&label=experimental&aligned&view=interop&q=path%3A%22%2Fpointerevents%2Fcoalesced_events_attributes_under_load.https.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fcoalesced_events_attributes.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fidlharness.window.html%22%20or%20path%3A%22%2Fpointerevents%2Fmouse-pointer-boundary-events-for-shadowdom.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_after_target_appended.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_attributes_hoverable_rightbutton.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_auxclick_is_a_pointerevent.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_boundary_events_at_implicit_release_hoverable_pointers.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_capture_suppressing_mouse.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_click_during_capture.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_click_is_a_pointerevent_multiple_clicks.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_click_is_a_pointerevent.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_constructor.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_contextmenu_is_a_pointerevent.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_fractional_coordinates.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_mouse_capture_change_hover.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_mouse_pointercapture_inactivate_pointer.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_pointermove_on_chorded_mouse_button.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_pointerout_no_pointer_movement.html%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_releasepointercapture_events_to_original_target.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_sequence_at_implicit_release_on_click.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fpointerevent_touch-action-keyboard.html%22%20or%20path%3A%22%2Fpointerevents%2Fpredicted_events_attributes.html%3Fmouse%22%20or%20path%3A%22%2Fpointerevents%2Fsynthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html%3FbuttonType%3DLEFT%26button%3D0%26buttons%3D1%22%20or%20path%3A%22%2Fpointerevents%2Fsynthetic-mouse-enter-leave-over-out-button-state-after-target-removed.tentative.html%3FbuttonType%3DMIDDLE%26button%3D1%26buttons%3D4%22

@zcorpan
Copy link
Member

zcorpan commented Feb 14, 2024

The spreadsheet with comments/motivations is at https://docs.google.com/spreadsheets/d/1GVqvTfRBh_film7kzMflCSJjIkq1TV4mRcPoldNSK1Q/edit?usp=sharing

The tests that have "recent consensus" implies that the spec hasn't been fixed yet to reflect the consensus. Where that is the case, I think it would be good to get the spec updated before including the corresponding test in Interop.

@mustaqahmed
Copy link
Member

The spreadsheet with comments/motivations is at https://docs.google.com/spreadsheets/d/1GVqvTfRBh_film7kzMflCSJjIkq1TV4mRcPoldNSK1Q/edit?usp=sharing

I will update the sheet now based on the comments above. If anyone wants to update the sheet, feel free to add your comment in Column F along with your email.

The tests that have "recent consensus" implies that the spec hasn't been fixed yet to reflect the consensus. Where that is the case, I think it would be good to get the spec updated before including the corresponding test in Interop.

Thanks for calling this out, we have two such tests. After revisiting the spec status for both just now, I concluded that they are safe to "include". Please let us know if anyone thinks otherwise:

  • pointerevent_after_target_appended.html?mouse: We learned yesterday that the spec is in good shape and the test needs a minor update (link).
  • pointerevent_pointerout_no_pointer_movement.html: the label in the sheet was wrong, oops! The spec was already correct (link).

@mustaqahmed
Copy link
Member

I will update the sheet now based on the comments above.

Done.

@zcorpan
Copy link
Member

zcorpan commented Feb 22, 2024

Thanks. OK for us to include.

@nairnandu
Copy link
Contributor Author

@nt1m / @aprotyas could you review the updated scope - pointerevents and uievents

@mustaqahmed
Copy link
Member

@nairnandu The 2024 dashboard entry for pointer/mouse events still point to the 2023 list. Is it time to include the added scope from your last comment?

@aprotyas
Copy link
Member

@nairnandu apologies for the delay here -- both scope changes look reasonable to me. I think we can proceed to reflecting this in the 2024 dashboard.

@nairnandu
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Pointer and Mouse Events test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

6 participants