Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern-plugin): support auto sidebar when is bilingual #432

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

10Derozan
Copy link
Member

@10Derozan 10Derozan commented Dec 5, 2023

Summary

It still exists problems in module plugin when autoSidebar.
This is the impactful way.

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit ae2f76d
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/656ef623777ddf00086bfe07
😎 Deploy Preview https://deploy-preview-432--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🟢 up 1 from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 merged commit e6a787f into main Dec 6, 2023
8 checks passed
@sanyuan0704 sanyuan0704 deleted the fix/modern-plugin branch December 6, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants