Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): adjust dev command marker #416

Merged
merged 1 commit into from
Dec 4, 2023
Merged

ci(e2e): adjust dev command marker #416

merged 1 commit into from
Dec 4, 2023

Conversation

10Derozan
Copy link
Member

Summary

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 4f0c410
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/656d7c20c8064e0008408b2f
😎 Deploy Preview https://deploy-preview-416--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🟢 up 2 from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@10Derozan 10Derozan marked this pull request as ready for review November 30, 2023 06:32
@sanyuan0704
Copy link
Collaborator

Awesome

sanyuan0704
sanyuan0704 previously approved these changes Nov 30, 2023
@9aoy
Copy link
Contributor

9aoy commented Nov 30, 2023

image

These cases have always had problems on Windows. Compilation fails but assertions can pass. Now it fails because we assert compilation was successful (compiled)

image

@10Derozan
Copy link
Member Author

image

These cases have always had problems on Windows. Compilation fails but assertions can pass. Now it fails because we assert compilation was successful (compiled)

image

This error should be caused by #423

@sanyuan0704 sanyuan0704 merged commit 8298623 into main Dec 4, 2023
8 checks passed
@sanyuan0704 sanyuan0704 deleted the ci/e2e branch December 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants