Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dark mode script during build when disabled in config #411

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

EmNudge
Copy link
Contributor

@EmNudge EmNudge commented Nov 29, 2023

Summary

Fixes the final build ignoring the user config setting themeConfig.darkMode: false (whereas it was previously respected in dev mode).

Related Issue

#372

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 2616dc2
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6566e187a5ab6700085ed54d
😎 Deploy Preview https://deploy-preview-411--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (no change from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmNudge EmNudge changed the title Fix/dark mode build fix: remove dark mode script during build when disabled in config Nov 29, 2023
@sanyuan0704
Copy link
Collaborator

Thanks

@sanyuan0704 sanyuan0704 merged commit 7841e4c into web-infra-dev:main Nov 29, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants