Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link and example on using components #1342

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

AkatQuas
Copy link
Contributor

@AkatQuas AkatQuas commented Aug 19, 2024

Summary

Add link and example for using components in pages.

Preview `en`

d688d9fb-483a-4963-8d72-4357edfeb6f8

Preview `cn`

image

Related Issue

close: #1284

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 389876d
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66c71e3e986ea80008a10cf1
😎 Deploy Preview https://deploy-preview-1342--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Collaborator

Timeless0911 commented Aug 19, 2024

#1284 This issue mainly describes the scenario of sharing mdx files, which means that there are the same parts that need to be imported in multiple mdx files. And the section you modified mainly describes the use of react components.

Can you write a separate section to describe how to use shared mdx files?

shared mdx

@AkatQuas
Copy link
Contributor Author

Is this section that you want do add?

@Timeless0911
Copy link
Collaborator

Is this section that you want do add?

Yes!

@AkatQuas
Copy link
Contributor Author

How about add a link to mdx documents to save our works?

@Timeless0911
Copy link
Collaborator

How about add a link to mdx documents to save our works?

I think it would be better for us to give an example ourselves. Just a simple sentence description and an example will do.

Copy link
Collaborator

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@Timeless0911 Timeless0911 enabled auto-merge (squash) August 22, 2024 11:19
@Timeless0911 Timeless0911 merged commit fd111ef into web-infra-dev:main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: Add a separate section to describe how to use shared mdx as components in other mdx files
2 participants