Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monaco editor webpack plugin #2890

Closed
zoolsher opened this issue Apr 23, 2023 · 7 comments
Closed

Support monaco editor webpack plugin #2890

zoolsher opened this issue Apr 23, 2023 · 7 comments
Assignees
Labels
A-plugin-compat Area: plugin compat feat New feature or request

Comments

@zoolsher
Copy link
Contributor

zoolsher commented Apr 23, 2023

What problem does this feature solve?

My web application is building with monaco-editor-webpack-plugin which doesn't work with rspack.

Link: https://github.com/microsoft/monaco-editor/blob/main/webpack-plugin/src/plugins/AddWorkerEntryPointPlugin.ts

What does the proposed API of configuration look like?

IMHO. This plugin requires API like childCompiler, LoaderTargetPlugin, etc.

@zoolsher zoolsher added feat New feature or request pending triage The issue/PR is currently untouched. labels Apr 23, 2023
@fuergaosi233
Copy link

I have the same problem 🙏

@hyf0 hyf0 added A-plugin-compat Area: plugin compat and removed pending triage The issue/PR is currently untouched. labels Apr 24, 2023
@hyf0 hyf0 added this to the Planned milestone Apr 24, 2023
@underfin underfin modified the milestones: Planned, 0.1.10 - Patch Apr 25, 2023
@underfin underfin modified the milestones: 0.1.11 - Patch, Planned Apr 25, 2023
@hardfist
Copy link
Contributor

hardfist commented May 5, 2023

blocked by #1320

@Boshen Boshen assigned ahabhgk and unassigned hardfist Jul 3, 2023
@suxiaoshao
Copy link

worker has been supported, when can support this plugin it, I use examples inside the monaco example, there are still some problems (such as clicking on the keyboard to delete the key will be deleted more), I hope to support this plugin as soon as possible, or there can be an alternative plugin.

@ahabhgk
Copy link
Contributor

ahabhgk commented Jul 11, 2023

You don't need the plugin if you use worker, check out example/monaco-editor-ts-react

@hardfist
Copy link
Contributor

@zoolsher please help check whether native worker supports fixes your issue?

@suxiaoshao
Copy link

You don't need the plugin if you use worker, check out example/monaco-editor-ts-react

I use examples inside the monaco example, there are still some problems (such as clicking on the keyboard to delete the key will be deleted more)

@hardfist
Copy link
Contributor

You don't need the plugin if you use worker, check out example/monaco-editor-ts-react

I use examples inside the monaco example, there are still some problems (such as clicking on the keyboard to delete the key will be deleted more)

can you file a separate issue or add more detailed information here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-plugin-compat Area: plugin compat feat New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants