This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Small sync fixes Helm operator #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
May 1, 2019
Due to the status of the HelmRelease being updated in two different processes, we sometimes got a "the object has been modified; please apply your changes to the latest version and try again" message back from the API. Fetching a fresh copy of the resource and applying the updates on top of that minimizes the chance this happens.
squaremo
reviewed
May 1, 2019
As the update function receives any update, and we do not want to run expensive dry-runs for status updates, but do want them for resyncs. Theoretically this should not result in resyncs being skipped, as a resync will redeliver a resource that was already known, which should equal to oldFhr.Status == newFhr.Status.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
HelmReleases before applying status updatesHelmReleasestatus updates while determining if it should proceed with the upgrade of aHelmRelease