This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Verify scanned keys in same build step as scan #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh-keyscan can get keys which then fail verification (e.g., if it misses out a host for some reason), but nonetheless cache the intermediate image, which will cause subsequent builds to fail. This is a pain to recover from. This commit changes the Dockerfiles such the verification is done in the same step as the keyscan -- so if it fails, the intermediate image won't be cached, and subsequent builds will do the keyscan again.
I wonder why ssh-keyscan doesn't exit with non-zero when that happens. It seems to be by design |
2opremio
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh-keyscan can get keys which then fail verification (e.g., if it misses out a host for some reason), but nonetheless Docker will cache the intermediate image, which will cause subsequent builds to fail. This is a pain to recover from.
This commit changes the Dockerfiles such the verification is done in the same step as the keyscan -- so if it fails, the intermediate image won't be cached, and subsequent builds will do the keyscan again.