Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message metadata on 'view report page' #458

Open
mhdirkse opened this issue Jul 1, 2024 · 10 comments
Open

Show message metadata on 'view report page' #458

mhdirkse opened this issue Jul 1, 2024 · 10 comments
Assignees
Labels
Backend Something to be changed in backend Frontend Something to be changed in frontend

Comments

@mhdirkse
Copy link
Member

mhdirkse commented Jul 1, 2024

When you open a report and click on the root node, the value of that node appears. Presently, only the XML of the report is shown. Niels Meijer asked whether along with that XML, report metadata can be shown. He suggested to put the metadata under the XML. The metadata may also be hidden so that it is only shown if you click somewhere. The most important item in this value window remains the XML of the report; the metadata is a nice addition.

@mhdirkse
Copy link
Member Author

mhdirkse commented Jul 1, 2024

@jacodg appte mij dat hij dit een goed issue vindt.

@mhdirkse
Copy link
Member Author

mhdirkse commented Jul 3, 2024

Ik heb de button over het hoofd gezien om metadata te tonen:

image

Blijft de suggestie van Niels over om de metadata onder de XML te hebben in plaats van erboven. Is dit een goed idee?

@MatthijsSmets
Copy link
Contributor

I think it makes more sense to have the metadata table at the top, like it is now, I'll close this because this is a styling suggestion and not an issue.

@nielsm5
Copy link

nielsm5 commented Jul 11, 2024

That's the ladybug's metadata, which is not what I was talking about.
We have over 30 keys we would like to display.

@nielsm5 nielsm5 reopened this Jul 11, 2024
@nielsm5
Copy link

nielsm5 commented Jul 11, 2024

Overigens, mijn doel is het inzichtelijk maken van de metadata, (niet ladybug metadata!!!). Waar het komt te staan maakt mij niet uit.

@jacodg
Copy link
Contributor

jacodg commented Jul 11, 2024

See also:
frankframework/frankframework#4208
frankframework/frankframework#3448
frankframework/frankframework#5163

@nielsm5 nielsm5 changed the title Show report metadata with top node value Show message metadata on 'view report page' Jul 15, 2024
@github-project-automation github-project-automation bot moved this to To do in Ladybug Jul 18, 2024
@mhdirkse
Copy link
Member Author

Ik denk dat dit niet alleen een frontend issue is. De metadata moet ook doorgegeven worden door de backend. Misschien moet ook het FF! worden aangepast om de metadata door te geven aan Ladybug's Testtool class.

@nielsm5
Copy link

nielsm5 commented Jul 21, 2024

Ik denk dat dit niet alleen een frontend issue is. De metadata moet ook doorgegeven worden door de backend. Misschien moet ook het FF! worden aangepast om de metadata door te geven aan Ladybug's Testtool class.

Dat klopt zeker. Het is nieuwe functionaliteit.

@MatthijsSmets MatthijsSmets moved this from To do to Needs response in Ladybug Jul 26, 2024
@nielsm5
Copy link

nielsm5 commented Aug 26, 2024

See also: frankframework/frankframework#4478

@jacodg
Copy link
Contributor

jacodg commented Aug 26, 2024

@MatthijsSmets for which question do you need response?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Something to be changed in backend Frontend Something to be changed in frontend
Projects
Status: To do
Development

No branches or pull requests

4 participants