Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds documentation for row sorting feature #239

Merged
merged 1 commit into from
Jun 4, 2017
Merged

adds documentation for row sorting feature #239

merged 1 commit into from
Jun 4, 2017

Conversation

y-chiasson
Copy link
Contributor

Hi, I needed to implement row sorting feature, started implementing all the code myself, then I realized that Fae already implemented that using jQuery sortable and a utilities controller for handling the model updates.. so I wrote documentation for it.

Also, I couldn't figure out why row sorting wasn't getting initialized after adding the js-sort-row class to the table... It turns out there is this code in app/assets/javascripts/fae/_tables.js#L29

if (FCH.exists('.sortable-handle') || FCH.exists('.main_content-sortable-handle')) {
  this.rowSorting();
 }

which requires the sortable-handle class to exist on a td element.. so I documented that too.

@jamesmk
Copy link
Member

jamesmk commented Jun 4, 2017

This is all generated for you if you use the rails g fae:scaffold with a position attr, but we are missing documentation on the feature. This is a good start, I'll merge this and expand on it.

Thanks for the PR @y-chiasson!

@jamesmk jamesmk merged commit 4165bc5 into wearefine:master Jun 4, 2017
@6temes 6temes deleted the add-documentation-for-row-sorting branch July 4, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants