Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons come with a background when using MaterialComponents #578

Closed
ashley-figueira opened this issue Apr 8, 2019 · 3 comments
Closed

Comments

@ashley-figueira
Copy link

ashley-figueira commented Apr 8, 2019

When using the library with Material Components, the material components will set a background color on the OK and Cancel buttons.

You have stated that there is not much you can do, but there actual is. All you have to do is to migrate to material components and set the style of the button to style="@style/Widget.MaterialComponents.Button.TextButton".

The TextButton style has a transparent background with colored text. Text buttons are used for low-priority actions, especially when presenting multiple options.

https://material.io/develop/android/components/material-button/

@ashley-figueira ashley-figueira changed the title Buttons come with a background whe using MaterialComponents Buttons come with a background when using MaterialComponents Apr 8, 2019
@wdullaer
Copy link
Owner

wdullaer commented Apr 8, 2019

I do not intend to add an additional dependency to this library.

There is another workaround proposal over here: #523 (comment)
It's a one line change to your code and avoids the support nightmare of an additional dependency for me.

@wdullaer wdullaer closed this as completed Apr 8, 2019
@ashley-figueira
Copy link
Author

Thank you for this. Did not notice that comment before.

@wdullaer
Copy link
Owner

wdullaer commented Apr 8, 2019

No worries, I've added it to the FAQ as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants