-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give minimap more threads when available. #18
Comments
That number only affects the building of the index, not the alignment itself. So changing this will not have too much effect. That said, it shouldn't be hardcoded to '8'. Chopper will, at the moment, when a contaminant is being filtered out, not use multithreading. The reason behind this is because it does not support using rayon. This may change in the future, and pull requests are appreciated. |
I'd be happy to give it a crack though I've never worked with rust. I see rayon is the parallelism library. Any tips before I attempt this? |
Well it shouldn't be done with rayon in this case, as that is not supported for minimap2-rs alignment. There are other options for parallelization, but none that I am sufficiently comfortable with. |
Here is an example for parallelization https://github.com/jguhlin/minimap2-rs/blob/main/fakeminimap2/src/main.rs |
Hello,
I noticed that here minimap is only given 8 threads. It would be nice if the threads flag was passed on to minimap.
The text was updated successfully, but these errors were encountered: