-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A package using dependencies.json as well as a module from Default is broken in ST4 #1570
Comments
Nothing that PC can do about this in particular, outside of getting |
I'll see what I can do about #1517 |
What about finding and importing the loader = sublime_plugin.multi_importer.find_module("Default")
mod = loader.load_module("Default")
sys.modules["Default"] = mod
import Default.exec |
@randy3k that's clever, but won't work anymore once the Default package starts using e.g. f-strings. I don't expect the Default to start using py38 features any time soon though :) good idea! |
With that comment you drive your whole request useless. The way to go for plugins ported to python 3.8 is to get rid of "Default" dependencies and do their job on their own. |
@deathaxe I'm not planning on using that hack, but I still think it's clever :) |
You might want to have a look how packa_control handles that, then. In injects itself into lib of both hosts. |
The following situation is somewhat tragic:
However, the Default package is now running in py38. So if a package imports something from Default and it uses dependencies.json, then there is currently no way to fix this.
Example: https://github.com/rwols/CMakeBuilder/blob/master/plugin.py uses Default.exec and the
tabulate
dependency.The text was updated successfully, but these errors were encountered: