-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string representations for procedures classes #43
Comments
I want to work on this issue, can you assign it to me? |
Hello @Aditya1001001 - typically we only assign issues to Waterloo Rocketry team members. Are you a member of the team? |
@jacobdeery I'm afraid I'm not a member of the team. Can you still assign it to me? |
@Aditya1001001 - Right now Topside is still in its early stages and we would like to save these issues as opportunities for newer team members to become familiar with the project. Thank you for your interest, though! |
@jacobdeery that's a bit disappointing. I'll just watch the repo for now. |
Hi @jacobdeery, I'm interested in working on this issue. Can you assign it to me? |
We haven't defined
__str__
methods forAction
,Transition
,Step
,Procedure
, or any of the condition classes, which means that when we print them we get things like this:<topside.procedures.conditions.GreaterEqual object at 0x0000024844702688>
Action(component='c1', state='open')
ProcedureStep(step_id='s1', action=None, conditions={<topside.procedures.conditions.Immediate object at 0x0000024815FC2748>: Transition(procedure='p1', step='s2')})
Procedure(procedure_id='p1', steps={'s1': ProcedureStep(step_id='s1', action=None, conditions={<topside.procedures.conditions.Immediate object at 0x0000024815FC2748>: Transition(procedure='p1', step='s2')}), 's2': ProcedureStep(step_id='s2', action=Action(component='c1', state='open'), conditions={<topside.procedures.conditions.Immediate object at 0x0000024844DA0448>: Transition(procedure='p1', step='s3')}), 's3': ProcedureStep(step_id='s3', action=Action(component='c1', state='closed'), conditions={})})
This isn't wrong, but when we want to add logging it will definitely be more convenient to have string representations so that it's easier to read.
The text was updated successfully, but these errors were encountered: