Group Builder API #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
feat/group-builder
branch
3 times, most recently
from
27151ef to
088a652
Compare
|
@passcod I think this is ready for review. |
passcod
requested changes
Mar 1, 2023
arlyon
force-pushed
the
feat/group-builder
branch
from
088a652 to
a45e6ff
Compare
arlyon
force-pushed
the
feat/group-builder
branch
from
a45e6ff to
a972f17
Compare
passcod
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new API with a builder pattern for setting certain flags that are not accessible to the group_spawn function if set on the Command object itself.
It also adds a few examples for basic sync, async, and a few with the builder as well.