Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esbuild 0.24.1 issue #2425

Closed
AlperGurel opened this issue Dec 20, 2024 · 4 comments
Closed

Fix esbuild 0.24.1 issue #2425

AlperGurel opened this issue Dec 20, 2024 · 4 comments

Comments

@AlperGurel
Copy link

AlperGurel commented Dec 20, 2024

Describe the bug
wasp start command fails on a newly created example to do project. With this error. I have been using wasp for over a month now, my project failed today with an error. When I try new project from wasp, it also failed.

To Reproduce
Steps to reproduce the behavior:

  1. Enter wasp new in terminal.

  2. Select todo-ts app by pressing 2 and enter.

  3. Type wasp db migrate-dev

  4. Type wasp start

Expected behavior
I should be able to see the app start successfully.

Screenshots
Image

Image

Desktop (please complete the following information):

  • Macos Sonama (M2 Chip)

Additional context
People over internet mention it is an esbuild problem so they were able to solve it by downgrading esbuild, but it didn't work for me.

@infomiho
Copy link
Contributor

infomiho commented Dec 20, 2024

I can confirm this also happens what I do the steps you described 👍 thank you for the report

Esbuild team track this here: evanw/esbuild#4010
Vite team tracks this here: vitejs/vite#19018

It should be fixed by this PR: evanw/esbuild#4013 (I suppose this will be then released in the next esbuild release).

Let's see if this get released today and that should be it. If it doesn't happen, we should quickly patch this since Wasp is now broken and you can't really work on new apps!

@hugomartinet
Copy link

Hi @infomiho,
Thanks for your report! Do you know of a way to bypass this issue in the meantime? Can we somehow tell wasp to use a previous version of esbuild?

I tried 2 options, but none worked..

1. Forcing vite version to a previous version

{
  "name": "my-app",
  "dependencies": {
    ...
  },
  "devDependencies": {
    ...
    "vite": "4.2.0"
  }
}

2. Overriding esbuild version in the vite dependencies

{
  "name": "my-app",
  "dependencies": {
    ...
  },
  "devDependencies": {
   ...
  },
  "overrides": {
    "vite": {
      "esbuild": 0.24.0
    }
  }
}

@patak-dev
Copy link

vite@6.0.5 is out pinning to esbuild 0.24.0 until this is fixed in esbuild, you can update to vite instead of doing the override

@infomiho
Copy link
Contributor

Thank you @patak-dev! This fixed our problem now :)

Wasp now works again @AlperGurel but we are still going to look into pinning some of our deps (e.g. Vite or our Rollup plugin for bundling the server) in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants