Various emscripten fixes #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
requested review from
bjfish,
Hywan and
MarkMcCaskey
as code owners
|
bors try |
tryBuild succeeded
|
MarkMcCaskey
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Looks good!
As a follow up PR we might want to change our use of cargo fmt -> cargo +stable fmt; I didn't suggest it in this PR because we already have cargo fmt in the Makefile. But CI checks for stable formatting and formatting with nightly can cause the lint to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various emscripten fixes:
Review