feat(runtime-c-api) Allow to call wasmer_export_func_call with null inputs and a 0 arity
#756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
|
bors try |
tryBuild succeeded
|
nlewycky
reviewed
Sep 5, 2019
|
bors r+ |
|
👎 Rejected by too few approved reviews |
syrusakbary
approved these changes
Sep 6, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 6, 2019
756: feat(runtime-c-api) Allow to call `wasmer_export_func_call` with null inputs and a 0 arity r=syrusakbary a=Hywan Fix #753 This PR allows to call `wasmer_export_func_call` with inputs set to NULL, and an arity of 0. It avoids to create an empty inputs array. So basically: ```c wasmer_export_func_call(exported_function, NULL, 0, …, …); ``` instead of: ```c wasmer_value_t inputs = {}; wasmer_export_func_call(exported_function, inputs, 0, …, …); ``` This PR also updates the test suite for exports. Instead of just the famous `sum` function, we now test more functions, so that all Wasm types are covered, including void functions. Finally, this PR updates the `wasmer_export_func_call` signature to forbid negative arities. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build succeeded
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #753
This PR allows to call
wasmer_export_func_callwith inputs set to NULL, and an arity of 0. It avoids to create an empty inputs array. So basically:instead of:
This PR also updates the test suite for exports. Instead of just the famous
sumfunction, we now test more functions, so that all Wasm types are covered, including void functions.Finally, this PR updates the
wasmer_export_func_callsignature to forbid negative arities.