Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert panic to error when calling emscripten main #690

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Convert panic to error when calling emscripten main #690

merged 1 commit into from
Aug 17, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Aug 17, 2019

Fixes #685

@bjfish
Copy link
Contributor Author

bjfish commented Aug 17, 2019

bors try

bors bot added a commit that referenced this pull request Aug 17, 2019
@bors
Try #690:
292c8c3
@bjfish
Copy link
Contributor Author

bjfish commented Aug 17, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 17, 2019
@bors @bjfish
Merge #690
162723a 
690: Convert panic to error when calling emscripten main r=bjfish a=bjfish

Fixes #685 

Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 17, 2019

Build failed

@bjfish
Copy link
Contributor Author

bjfish commented Aug 17, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 17, 2019
@bors @bjfish
Merge #690
0a3182e 
690: Convert panic to error when calling emscripten main r=bjfish a=bjfish

Fixes #685 

Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 17, 2019

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented Aug 17, 2019

Build succeeded

@bors bors bot merged commit d899909 into master Aug 17, 2019
@bors bors bot deleted the feature/fix-panic-calling-emscripten-main branch August 17, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasmer] panic! triggered in run_emscripten_instance (lib/emscripten/src/lib.rs)
2 participants
@bjfish @syrusakbary