Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASIX: Align Threads Implementation With Proposed Standard #3622

Closed
theduke opened this issue Feb 23, 2023 · 5 comments
Closed

WASIX: Align Threads Implementation With Proposed Standard #3622

theduke opened this issue Feb 23, 2023 · 5 comments
Assignees
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Milestone

Comments

@theduke
Copy link
Contributor

theduke commented Feb 23, 2023

Align the WASIX threads implementation with the proposed standard: https://github.com/WebAssembly/wasi-threads .

The only relatively minor required change is exposing stack information via globals instead of passing them in the spawn syscall.

@theduke theduke added 🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. labels Feb 23, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Feb 28, 2023
@ptitSeb ptitSeb added this to the v3.3 milestone Feb 28, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.0 Apr 20, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Apr 20, 2023

Needs some check

@syrusakbary
Copy link
Member

This was fixed by #3774 . Closing

@theduke
Copy link
Contributor Author

theduke commented May 3, 2023

No this was not done, we only added support for upstream, we didn't switch WASIX to use the same abi.

@theduke theduke reopened this May 3, 2023
@theduke
Copy link
Contributor Author

theduke commented May 3, 2023

@john-sharratt was there a reason for keeping the divergence (pointer arg vs return value)?

@john-sharratt
Copy link
Contributor

john-sharratt commented May 17, 2023

WASIX is not going to use the exact same ABI for this while its still under development, once its properly standardized it can be reopened.
WASI threads is already fully supported via its experimental ABI (that's in its own namespace) which is converged into the same implementation and should be fully functional; although we need the community to build some WASI test cases for this to add to the regression suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants