Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: Re-enable WAI Bindings Generation & Test #3604

Closed
theduke opened this issue Feb 22, 2023 · 1 comment
Closed

wasi: Re-enable WAI Bindings Generation & Test #3604

theduke opened this issue Feb 22, 2023 · 1 comment
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Milestone
v4.x

Comments

@theduke
Copy link
Contributor

theduke commented Feb 22, 2023

#3422 disabled the test that ensures the WAI generated type bindings in the wasi-types crate are up to date.

The reason is that the bindings would require a manual cleanup to be correctly usable.

This should be re-enabled, either by:

  • Adding the required fixes to the other already present fixes (see wasi-types/wasi-typesgenerator)
  • Improving the WAI Rust bindings generator
@theduke theduke added 🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. labels Feb 22, 2023
This was referenced Feb 22, 2023
Merged
Closed
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Feb 28, 2023
@ptitSeb ptitSeb added this to the v3.3 milestone Feb 28, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.x Apr 20, 2023
@theduke
Copy link
Contributor Author

theduke commented Jul 18, 2024

WAI suport was removed, no longer relevant.

@theduke theduke closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Projects
None yet
Milestone
v4.x
Development

No branches or pull requests
3 participants
@theduke @ptitSeb @Michael-F-Bryan