-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASIX: Architecture-Independent StackSnapshot Alignment #3602
Labels
🎉 enhancement
New feature!
lib-wasix
Issues related to the WASIX toolchain.
priority-low
Low priority issue
Milestone
Comments
theduke
added
🎉 enhancement
New feature!
lib-wasix
Issues related to the WASIX toolchain.
labels
Feb 22, 2023
theduke
changed the title
WASIX: Solve StackSnapshot Alignment
WASIX: Architecture-Independent StackSnapshot Alignment
Feb 22, 2023
This was referenced Feb 22, 2023
Merged
assigned to syrus for later assignment. |
Main type aligment done. Need some 2nd look on that later. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
Feel free to reopen the issue if it has been closed by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🎉 enhancement
New feature!
lib-wasix
Issues related to the WASIX toolchain.
priority-low
Low priority issue
The
StackSnapshot
type used by wasix is currently defined as au128
, which creates alignment issues on different CPU architectures, for example because ARM has different alignment requirements.The type should be replaced to be free of alignment issues, like a multiple
u32
.This may also require updates to:
https://github.com/john-sharratt/wasix
(This currently has the type defined with two
u64
fields...https://github.com/wasmerio/wasix-libc
The text was updated successfully, but these errors were encountered: