Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-c-api should not copy files to manifest directory #354

Closed
MarkMcCaskey opened this issue Apr 12, 2019 · 2 comments
Closed

runtime-c-api should not copy files to manifest directory #354

MarkMcCaskey opened this issue Apr 12, 2019 · 2 comments
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api

Comments

@MarkMcCaskey
Copy link
Contributor

cargo publish is unhappy with modifications happening outside of OUT_DIR when running build.rs.

@MarkMcCaskey MarkMcCaskey added bug Something isn't working 📦 lib-c-api About wasmer-c-api labels Apr 12, 2019
@bjfish
Copy link
Contributor

bjfish commented Apr 13, 2019

I'm guessing the current build must changing the last modified time of the file and complaining about that since the contents shouldn't change.

I wonder if we could configure the header generator not to modify the file if the contents have not changed.

Link to rust feature:
rust-lang/cargo#5584

@Hywan
Copy link
Contributor

Hywan commented Oct 16, 2020

@MarkMcCaskey I believe we can close this issue now. Feel free to reopen if you think it's still relevant somehow.

@Hywan Hywan closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api
Projects
None yet
Development

No branches or pull requests

3 participants