Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream wasi-types-generator-extra into wit-bindgen #3209

Open
fschutt opened this issue Sep 29, 2022 · 4 comments
Open

Upstream wasi-types-generator-extra into wit-bindgen #3209

fschutt opened this issue Sep 29, 2022 · 4 comments
Assignees
Labels
bug Something isn't working priority-medium Medium priority issue

Comments

@fschutt
Copy link
Contributor

fschutt commented Sep 29, 2022

We need to remove lib/wasi-types/wasi-types-generator-extra/src/main.rs and upstream the functionality (bitflags support for repr(u16)) into wit-bindgen.

@fschutt fschutt added the bug Something isn't working label Sep 29, 2022
@fschutt fschutt self-assigned this Sep 29, 2022
@fschutt
Copy link
Contributor Author

fschutt commented Sep 29, 2022

Currently blocked because #3177 is not yet merged.

@syrusakbary
Copy link
Member

Context: we would like to remove this code: https://github.com/wasmerio/wasmer/pull/3177/files#diff-8747a217eb303dd2584bcdc0796a5c82cb097ac73eb7655c8c49ecfe765fa45bR28-R51

And wit-bindgen doesn't seem to want to support the older repr: bytecodealliance/wit-bindgen#323

@syrusakbary syrusakbary added the priority-medium Medium priority issue label Oct 4, 2022
@stale
Copy link

stale bot commented Oct 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Oct 5, 2023
Copy link

stale bot commented Nov 4, 2023

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Nov 4, 2023
@theduke theduke reopened this Nov 4, 2023
@stale stale bot removed the 🏚 stale Inactive issues or PR label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants