Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning false on beforeChange callback has no effect #749

Closed
ghiculescu opened this issue Jun 5, 2013 · 4 comments
Closed

returning false on beforeChange callback has no effect #749

ghiculescu opened this issue Jun 5, 2013 · 4 comments
Labels

Comments

@ghiculescu
Copy link
Contributor

The documentation states that:

To cancel all edit, return false from the callback or set array length to 0 (changes.length = 0).

For the beforeChange event. However, returning false does not cancel the edit. It seems that in line 1536 the call to the callback is done via instance.runHooks, but the runHooks function on line 2585 doesn't return anything.

Setting the length of the changes array to 0 seems to work. Is returning false no longer supported?

@setthase
Copy link

setthase commented Jun 5, 2013

This will be fixed soon.

@warpech
Copy link
Member

warpech commented Jun 6, 2013

This should be now fixed in Handsontable 0.9.4. Can you please check and let us know if it works OK for you now?

@warpech warpech closed this as completed Jun 6, 2013
@Shemulik
Copy link

It is not fixed

@AMBudnik
Copy link
Contributor

Hi @Shemulik This issue was closed 9 years ago. Could you please provide us your configuration and steps to replicate the issue at support@handsontable.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants