Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numeric #658

Closed
gbelmm opened this issue May 14, 2013 · 5 comments
Closed

numeric #658

gbelmm opened this issue May 14, 2013 · 5 comments
Labels

Comments

@gbelmm
Copy link

gbelmm commented May 14, 2013

supports not enter negative numbers

http://handsontable.com/demo/numeric.html

example

-10

@Makimeishu
Copy link

When I enter non-numeric characters, its allowed as well. Is it a bug, or we need to do data validation for it?

@edallen
Copy link

edallen commented May 15, 2013

Also try a fill down from the value in top row of the example at http://handsontable.com/demo/numeric.html
I see
7.000,00 euros
69.999.999,00 euros
69.999.999,00 euros

@setthase
Copy link

@Makimeishu - this is allowed. You need do your own validation for preventing non-numeral values.

@edallen - this is because demo provide internationalization feature. In this case there is error in numeral.js or with this internationalization file. Numbers with dots are used as thousands separator, so value of first cell (6999.999) is wrongly used as 69 999 999.00

@josegrad
Copy link

I'm a bit confused with the behavior.
I can notice some things with this fiddle: http://jsfiddle.net/mEHDG/14/

I'm on OSX Snow Leopard

1- In Firefox v21.0 I cannot enter a minus sign before the numbers
2- In Chrome and Safari I can enter the minus sign but the formatting is not applied. This is not terrible but confusing for the users as they type in values

@warpech
Copy link
Member

warpech commented Jun 6, 2013

This should be now fixed in Handsontable 0.9.4 (commit beabe2f)

Can you check if it now works as desired?

I also enhanced the Numeric cell type demo with additional column that uses the default locale (en / US): http://handsontable.com/demo/numeric.html

@warpech warpech closed this as completed Jun 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants