Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal scroll bar not move till end after defining "fixedColumnsLeft" option. #645

Closed
gururajiv opened this issue May 10, 2013 · 8 comments

Comments

@gururajiv
Copy link

Hi ,

I have set "fixedColumnsLeft: 2" in handsontable constructor. it is working fine. but when i am trying to scroll right in grid. The scrollbar not seems to work as expected. it moves the scrollbar two cells back.

thanks,

@bgrohman
Copy link
Contributor

I see something similar as well. When I scroll using the horizontal scroll bar and 1 fixed left column, it works until I get to the end of the scroll area. Once the last column is visible, I should not have any more area to scroll into, but the scroll bar continues to move. When it moves past where the last column is, the grid sort of jumps and displays the columns as if I had scrolled in the opposite direction.

@bgrohman
Copy link
Contributor

Update: I can also see this when there are no fixed columns. Manually resizing one of the columns seems to fix it.

@bgrohman
Copy link
Contributor

@warpech Is there any estimate on when this issue will be addressed?

bgrohman added a commit to bgrohman/jquery-handsontable that referenced this issue May 22, 2013
This fixes the case when the horizontal scroll bar will not allow you to scroll to see the last column when using fixed columns.
@bgrohman bgrohman mentioned this issue May 22, 2013
@warpech
Copy link
Member

warpech commented May 23, 2013

Could you @bgrohman or @gururajiv provide a JSFiddle or test case to the pull request?

I know there is "some" issue there but I cannot isolate the very issue that is fixed by this pull request. Ideally a pull request should contain a test case that proves its purpose

@bgrohman
Copy link
Contributor

@warpech Here's a jsFiddle. I'll make sure to include a jsfiddle for any new issues I open.

http://jsfiddle.net/b0x47/D7erp/

@warpech
Copy link
Member

warpech commented May 29, 2013

Thanks a lot. This will be merged today.

@bgrohman
Copy link
Contributor

@warpech You're welcome, and thank you for Handsontable!

@warpech
Copy link
Member

warpech commented Jun 3, 2013

This should be now fixed in version 0.9.3. Thanks for everyone involved in solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants