Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change source always 'populateFromArray' #566

Closed
provegard opened this issue Apr 15, 2013 · 2 comments
Closed

Change source always 'populateFromArray' #566

provegard opened this issue Apr 15, 2013 · 2 comments
Labels
bug

Comments

@provegard
Copy link

I noticed that the change source in my onChange handler is always populateFromArray. Using version 0.8.19.

The problem seems to be that HandsontableTextEditorClass.prototype.finishEditing passes 5 arguments to populateFromArray, which accepts only 4. The value for source will be the 4th argument, which is false, meaning that the default change source is used.
@warpech
Copy link
Member

warpech commented Apr 15, 2013

Thanks! This will be fixed in 0.8.20

warpech added a commit that referenced this issue Apr 16, 2013
@warpech
Bugfix: source parameter should be edit when cell value is changed …
1c6e3ef 
…through editor (#566)
@warpech
Copy link
Member

warpech commented Apr 19, 2013

Thanks once again for reporting. This is now fixed in 0.8.20

@warpech warpech closed this as completed Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warpech @provegard