Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outsideClickDeselects : false disables all focus in other inputs outside the table #408

Closed
danielrefchke opened this issue Feb 14, 2013 · 11 comments
Labels

Comments

@danielrefchke
Copy link

when outsideClickDeselects is set to false, all inputs outside the container never gain the focus. Try this code:

<div><input value="try this"/></div>
  <div id='install'></div>  
<script>
        $("#install").handsontable({
             data :[
             [1,2,3,4,5],
             [1,2,3,4,5],
             [1,2,3,4,5],
             [1,2,3,4,5],
             ],
             startRows: 5,
             startCols: 5,
             colHeaders: true,
             rowHeaders: true,
             manualColumnResize: true,
             minSpareRows: 1,
             minSpareCols:1,
             outsideClickDeselects : false
        })
</script>
@warpech
Copy link
Member

warpech commented Feb 18, 2013

Thanks, I am able to reproduce it. I will fix this when possible.

I creted a JSFiddle from the code that you provided: http://jsfiddle.net/warpech/84Uch/1/

@warpech
Copy link
Member

warpech commented Feb 18, 2013

Actually this issue is a duplicate of #401. I will treat this as a +1 :)

warpech added a commit that referenced this issue Mar 18, 2013
@warpech
Copy link
Member

warpech commented Mar 18, 2013

This should be now fixed in 0.8.15, thanks for the report!

@warpech warpech closed this as completed Mar 18, 2013
@marint
Copy link

marint commented Mar 19, 2013

Hi, focus on select tags still seems to disabled, so it should probably also be added?

if (target.nodeName.toLowerCase() === 'input' || target.nodeName.toLowerCase() === 'textarea' || target.nodeName.toLowerCase() === 'select')

@dansabirov
Copy link

Hi, @warpech

In some cases it is needed to keep selection, because you need to know which row was selected for example.

In my cases I commented lines for if clause when outsideClickDeselects is false, it is worked.

May be add one more option addition for outsideClickDeselects that will tell keep selection or not when it was outside click

@warpech
Copy link
Member

warpech commented Mar 26, 2013

This issue should now be fixed in Handsontable 0.8.16.

We changed the logic behind outsideClickDeselects. Could you please upgrade and test if it works for you?

@warpech warpech closed this as completed Mar 26, 2013
@danielrefchke
Copy link
Author

works fine!!!, thanks!!!

@dansabirov
Copy link

@warpech thanks a lot!!! Works fine!

@ghost
Copy link

ghost commented Jun 26, 2013

The following doesn't work for me on firefox 22.0 but on chrome it works.

When a cell is selected you can't change the selected value in the drop down menu.

http://jsfiddle.net/yoyle/P6RFn/

@setthase
Copy link

I confirm! We will try to fix this as soon as possible.

@psmolenski
Copy link
Contributor

Fixed in 0.9.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants