new test to showcase onChange bug when triggered via 'edit' #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug and an inconsistency on the data object that is passed as parameter on the callback of the
onChange
event.I have written this test to illustrate the issues. It is triggered when changing the contents of the table via the
setDataAtCell
method, which results in triggering anonChange
event with the sourceType ofedit
.The _bug_ is that no previous value is defined, the array index 2 should contain the previous value of the cell before it was changed. The value of that index is
undefined
, which apparently is a bug.The _inconsistency_ is on the
col
field, or array index 1. When the event is triggered with thesetDataAtCell
method (sourcetype
) the value of thecol
is its numeric representation.When the event is triggered by the user editing on the table (source
populateFromArray
) then the col has the value that was defined in the data as key.e.g.