Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent undo/redo behavior #1262

Closed
mariotacke opened this issue Jan 10, 2014 · 3 comments
Closed

Inconsistent undo/redo behavior #1262

mariotacke opened this issue Jan 10, 2014 · 3 comments
Labels
Milestone

Comments

@mariotacke
Copy link

Hello,

please consider the following fiddle for the example I will be describing:
http://jsfiddle.net/92mV3/

Handsontable incorrectly un-dos/re-dos actions after one correct undo. I think the example will show it best. Additionally, the undo seems to go further than what the history tells it to. In the fiddle, try to CTRL - Z past 3 tries. It will delete the table.

Here is another fiddle where I tried to abstract the problem further: http://jsfiddle.net/43EWa/ same behavior, however...

Any advice? I have a feeling that it has to do with the OSX fix for CMD and CTRL, but that is just what my gut tells me.

Thanks! Mario

@ghost ghost assigned psmolenski Jan 13, 2014
psmolenski added a commit that referenced this issue Feb 4, 2014
@psmolenski
Copy link
Contributor

The strange behavior turned to be caused by the way minSpareRows property is handled. I belive, I've managed to fix the bug. Could you please verify if my patch works?

@mariotacke
Copy link
Author

Thank you Marcin. I have a hard time building the package via grunt and thus am unable to test it unless compiled. Is there any chance you can provide me with the .js file? Sorry, I am a novice when it comes to github.

@psmolenski
Copy link
Contributor

Fixed in 0.10.3. Please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants