Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectEditor dropdown hidden #1176

Closed
AndreaCuneo opened this issue Nov 15, 2013 · 9 comments
Closed

SelectEditor dropdown hidden #1176

AndreaCuneo opened this issue Nov 15, 2013 · 9 comments
Labels

Comments

@AndreaCuneo
Copy link

In 10.0.beta3 the SelectEditor is working only using arrow keys. The select dropdown is not displayed.

If this is a feature, can you please hint me about what i should extend?

@psmolenski
Copy link
Contributor

Please, prepare a jsFiddle

@AndreaCuneo
Copy link
Author

Here it is. http://jsfiddle.net/hU6Kz/2467/

Column B is using SelectEditor. As you can see, the dropdown is not visible while working with arrow keys.

@psmolenski
Copy link
Contributor

Definitely, it's a bug.

@ghost ghost assigned psmolenski Nov 15, 2013
@AndreaCuneo
Copy link
Author

If you can provide hints what I should looking for, I can try to work up a solution. I already spent time on this without luck. Maybe the dropdown is either hidden behind the table or the click on the dropdown is intercepted before reaching the select element.

@psmolenski
Copy link
Contributor

I can see the <select> box in the cell, but after clicking on in the list doesn't show. I would guess that it has something to do with click event. Maybe some code invokes preventDefault() or stopPropagation() on event object?

@AndreaCuneo
Copy link
Author

That was my guess too, but I don't know how to follow the event object that doesn't reach the DOM element ... and I think it should generate from it and then bubbling up. How can be intercepted before reaching a child element?

In any case, I don't know how i can intercept the click event and "follow" it. Do you have any "tutorial" on this?

@yahoops
Copy link

yahoops commented Dec 10, 2013

we've found the preventDefault() blocking the display.
somewhere around l2700 on handsontable full
in : Handsontable TableView constructor there is an event listener

instance.rootElement.on('mousedown.handsontable', function (event) {
if (!that.isTextSelectionAllowed(event.target)) {
clearTextSelection();
event.preventDefault();
}

we've not checked a lot the purpose of the event so for our own purpose we've added a test : if the event target is a select, do not prevent. a better solution may(must) exist.

@psmolenski
Copy link
Contributor

I have recently fixed this issue (81fc12c). My fix will be released in version 0.10.0 (final)

@warpech
Copy link
Member

warpech commented Dec 29, 2013

This should be fixed in 0.10.0. Could you please recheck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants