Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source maps to the repo #1010

Closed
warpech opened this issue Aug 28, 2013 · 2 comments
Closed

Add source maps to the repo #1010

warpech opened this issue Aug 28, 2013 · 2 comments

Comments

@warpech
Copy link
Member

warpech commented Aug 28, 2013

As pointed in #1009, Chrome Developer Tools show 404 (Not Found) error message about missing source maps:

.../jquery-handsontable/lib/jquery-1.10.2.min.map
.../jquery-handsontable/dist/json-patch-duplex.js.map

As solution I propose to add missing source maps and files to which they link (without altering the files that contain the source map reference)

I'd rather keep the source maps, because this is also what jQuery does in their minified, production-ready files: http://jquery.com/download/

This issue only affects Chrome users with "Enable source maps" option enabled in the Developer Tools.

@jdivock
Copy link

jdivock commented Sep 23, 2013

Just chiming in that I'm experiencing this as well

@psmolenski
Copy link
Contributor

I've added the missing source maps, however, now there has to be a json-patch-duplex.ts file in the dist directory and I looks kind of messy. Maybe we should leave only jQuery source map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants