fix/improvement for #85

Author: wardz

ClassicCastbars/core/Frames.lua

@@ -618,7 +618,11 @@ function ClassicCastbars:SkinPlayerCastbar()
     self:SetCastbarFonts(CastingBarFrame, db)
 
     if not isRetail then
-        hooksecurefunc("CastingBarFrame_OnLoad", ColorPlayerCastbar)
+        if not CastingBarFrame.CC_ColorIsHooked then
+            hooksecurefunc("CastingBarFrame_OnLoad", ColorPlayerCastbar)
+            CastingBarFrame.CC_ColorIsHooked = true
+        end
+
         C_Timer.After(GetTickTime(), ColorPlayerCastbar)
     else
         if PlayerCastingBarFrame.isTesting then
@@ -632,22 +636,27 @@ end
 if isRetail then
     -- Modified code from Classic Frames, some parts might be redundant for us.
     -- This is mostly just quick *hacks* to get the player castbar customizations working for retail after patch 10.0.0.
+    -- Once 'player-castbar-v2' branch is done this will all be removed.
     hooksecurefunc(PlayerCastingBarFrame, 'UpdateShownState', function(self)
         local db = ClassicCastbars.db and ClassicCastbars.db.player
         if not db or not db.enabled then return end
 
-        if self.barType ~= "empowered" then
+        --if self.barType ~= "empowered" then
             self:SetStatusBarTexture("Interface\\TargetingFrame\\UI-StatusBar")
+            if self.barType == "empowered" then
+                self.Spark:SetAtlas(nil)
+            end
             self.Spark:SetTexture("Interface\\CastingBar\\UI-CastingBar-Spark")
             self.Spark:SetSize(32, 32)
             self.Spark:ClearAllPoints()
-            self.Spark:SetPoint("CENTER", 0, 2)
+            self.Spark:SetPoint("CENTER", self, "LEFT", 0, 0)
+            self.Spark.offsetY = 0
             self.Spark:SetBlendMode("ADD")
-            if self.channeling then
+            if self.channeling and self.barType ~= "empowered" then
                 self.Spark:Hide()
             end
             ClassicCastbars:SkinPlayerCastbar()
-        end
+        --end
     end)
 
     hooksecurefunc(PlayerCastingBarFrame, "FinishSpell", function(self)