Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 xdebug configuration needs updated #398

Closed
navarr opened this issue Jun 29, 2021 · 3 comments
Closed

PHP8 xdebug configuration needs updated #398

navarr opened this issue Jun 29, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@navarr
Copy link
Member

navarr commented Jun 29, 2021

Getting these errors:

Xdebug: [Config] The setting 'xdebug.auto_trace' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.auto_trace (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.profiler_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.profiler_enable_trigger' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_enable_trigger (See: https://xdebug.org/docs/errors#CFG-C-CHANG
ED)
Xdebug: [Config] The setting 'xdebug.profiler_output_dir' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_output_dir (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_autostart' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_autostart (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_connect_back' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_connect_back (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_host' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_host (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.trace_output_dir' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.trace_output_dir (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.trace_enable_trigger' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.trace_enable_trigger (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
@davidalger davidalger transferred this issue from davidalger/docker-images-php Jun 29, 2021
@davidalger
Copy link
Collaborator

@navarr Transferred this into the Warden issue tracker. The upstream base PHP images don't provide Xdebug, it's layered into the Warden images via the Dockerfiles in here.

It seems what is happening is, there is no Xdebug2 for PHP 8, and instead of failing the build it's installing the xdebug3 package automatically when php-pecl-xdebug is installed:

image

Does this still occur if you include PHP_XDEBUG_3=1 in your .env file? Assuming it does not (and it shouldn't, given the work in #279 introduced these Xdebug3 ready images with the newer configuration settings), then it sounds like the debug image variant builds need to be blocked for PHP 8 and PHP_XDEBUG_3=1 forcefully set when PHP_VERSION is >= 8.0 since Xdebug 2 isn't supported. And there should probably be a note in the docs regarding this.

Thoughts?

@navarr
Copy link
Member Author

navarr commented Jun 30, 2021

@davidalger Good call, I must've missed that update. This issue does not occur with PHP_XDEBUG_3=1 in the .env file.

Forcing it for 8.0+ is probably the right call.

@stale
Copy link

stale bot commented Sep 28, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 28, 2021
@davidalger davidalger added bug Something isn't working and removed stale labels Sep 30, 2021
@navarr navarr closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants