Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem (precision) with the SHC tests #269

Closed
giovannipizzi opened this issue Apr 29, 2019 · 3 comments · Fixed by #323
Closed

Problem (precision) with the SHC tests #269

giovannipizzi opened this issue Apr 29, 2019 · 3 comments · Fixed by #323
Assignees
Milestone

Comments

@giovannipizzi
Copy link
Member

The new SHC tests (introduced in #264 by @qiaojunfeng) are failing on some compilers, see:

http://130.186.13.169:8010/#/builders/15/builds/20/steps/5/logs/stdio

http://130.186.13.169:8010/#/builders/12/builds/26/steps/5/logs/stdio

http://130.186.13.169:8010/#/builders/18/builds/22/steps/6/logs/stdio

Is this expected (and increasing the threshold in the tests is ok) or does it hint at a bug?

@qiaojunfeng
Copy link
Collaborator

It seems that all the errors are less than 1e-2 relative to the benchmark values. I don't have much experience in these precision issues of compilers, but from a physical point of view, these results are acceptable.

@giovannipizzi
Copy link
Member Author

Fixed in #273

@giovannipizzi
Copy link
Member Author

I'm actually reopening this - there are still two tests failing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants