fix: revert blob add by default #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
commented
May 15, 2024
| @@ -156,7 +156,7 @@ export class Client extends Base { | |||
| /** | |||
| * Get a receipt for an executed task by its CID. | |||
| * | |||
| * @param {import('multiformats').UnknownLink} taskCid | |||
| * @param {import('multiformats').UnknownLink} taskCid - Task CID for receipt. | |||
There was a problem hiding this comment.
to then trigger release please for w3up-client
vasco-santos
force-pushed
the
fix/revert-blob-add-by-default
branch
from
c0b47c0 to
0392385
Compare
alanshaw
approved these changes
May 15, 2024
vasco-santos
force-pushed
the
fix/revert-blob-add-by-default
branch
from
0392385 to
3342dcc
Compare
This was referenced May 15, 2024
vasco-santos
pushed a commit
that referenced
this pull request
May 15, 2024
🤖 I have created a release *beep* *boop* --- ## [14.1.1](upload-client-v14.1.0...upload-client-v14.1.1) (2024-05-15) ### Fixes * revert blob add by default ([#1456](#1456)) ([b77ec75](b77ec75)) * upload client export blob ([#1454](#1454)) ([5e55900](5e55900)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vasco-santos
added a commit
that referenced
this pull request
May 15, 2024
🤖 I have created a release *beep* *boop* --- ## [13.1.1](w3up-client-v13.1.0...w3up-client-v13.1.1) (2024-05-15) ### Fixes * revert blob add by default ([#1456](#1456)) ([b77ec75](b77ec75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
vasco-santos
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit b77ec75.
alanshaw
pushed a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did a release while not ready