Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BLS crypto type for Substrate #39

Closed
drskalman opened this issue Dec 7, 2021 · 3 comments
Closed

Implement BLS crypto type for Substrate #39

drskalman opened this issue Dec 7, 2021 · 3 comments
Assignees

Comments

@drskalman
Copy link
Collaborator

Substrate requires a crypto type similar to: https://github.com/paritytech/substrate/blob/master/primitives/application-crypto/src/ecdsa.rs to be able to instantiate a signer for beefy capable of bls sigining. Implementing such crypto types help implementers to kick off BLS on beefy.

@drskalman drskalman self-assigned this Dec 7, 2021
@drskalman
Copy link
Collaborator Author

This is related to: paritytech/substrate#10469

@drskalman
Copy link
Collaborator Author

2912fa1b1b implements BLS Signature core crypto. Remains to make the tests compile and pass

It is also not clear for me what to set the context for the messages before they get signed in:

sig.verify(Message::new(b"ctx", message.as_ref()), &public_key)

It is abscent for ed25519 crypto. @burdges, @AlistairStewart?

@drskalman
Copy link
Collaborator Author

The (draft) pull request is ready: paritytech/substrate#11574 searching for some reviewer now.

All bls crypto test pass.

uint::tests::test_u256 fails for some strange reason:

failures:

---- uint::tests::test_u256 stdout ----
thread 'uint::tests::test_u256' panicked at 'called `Result::unwrap_err()` on an `Ok` value: 16', primitives/core/src/uint.rs:61:5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant