Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial TD validation #287

Closed
danielpeintner opened this issue Jan 11, 2021 · 2 comments · Fixed by #289
Closed

Partial TD validation #287

danielpeintner opened this issue Jan 11, 2021 · 2 comments · Fixed by #289

Comments

@danielpeintner
Copy link
Contributor

The scripting API produce() methods allows for passing a TD fragment argument. It is essentially a init dictionary of a TD.

We might want to have a proper validation of this TD fragment argument.
The idea is to use the existing JSON Schema form the ThingDescription document with the only difference that all "required": { ... } keywords are pruned.

Question: difference between TD model and TD fragment used in scripting.
see related discussion for TD model.

@relu91
Copy link
Member

relu91 commented Jan 18, 2021

I think we should rename this: "Partial TD validation". TD fragments are more relevant for TDD search answers.

@danielpeintner danielpeintner changed the title TD Fragment validation Partial TD validation Jan 18, 2021
@danielpeintner
Copy link
Contributor Author

Call 2021-01-18: @relu91 volunteered to work on a PR providing an algorithm to validate partial TD input (e.g., by re-using the JSON schema used in the TD spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants