Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "autocomplete has valid value" #501

Open
6 tasks
nitedog opened this issue Jan 14, 2021 · 2 comments
Open
6 tasks

Resolve "autocomplete has valid value" #501

nitedog opened this issue Jan 14, 2021 · 2 comments

Comments

@nitedog
Copy link
Contributor

nitedog commented Jan 14, 2021

This rule checks that "autocomplete has valid value":
Survey results

The survey discussed during:
12 November 2020 meeting

Kathy Eng:

  • Not clear on second assumption - it seems form fields that do not collect information about the user shouldn't or wouldn't have autocomplete. Is this assumption necessary given the first assumption that when autocomplete is present, it is collecting info about the user?
  • Passed 2, 3, 5, 6, 7 examples need more visible label info to confirm that the optional tokens in the the attribute values are correct.

Mary Jo Mueller:

  • Seems the 2nd paragraph in the assumptions indicate it is assumed this rule will produce false positives. For the last paragraph, the last sentence is not super-clear to me. If you qualify "If this is not the case" it would be clearer. I can't tell if the statement is indicating "If aria-disabled state is not used" or "if aria-disabled is used but the element is still operable". When you have a complex statement followed by a statement using "this" it is hard to parse if all of the things from the previous statement need to be true or some.
  • Seems like Passed example 8 should be inapplicable since the widget role is no longer an input - it is overridden by ARIA but not as an input, select or textarea.

Wilco Fiers:

  • The rule does not account for different types of disabled elements. Only the aria-disabled attribute. Inapplicable example 6 seems like it should be a pass instead.
  • I'm not too keen on passed example 8. Can we find a better role for this?
@WilcoFiers
Copy link
Collaborator

PR approved, merging today, should be ready for another review: act-rules/act-rules.github.io#1534

@WilcoFiers
Copy link
Collaborator

Has 2 open issues to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants