Directional language-tagged strings #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently WIP. |
afs
force-pushed
the
langdir
branch
3 times, most recently
from
701e3a1
to
571ef20
Compare
TallTed
suggested changes
Jul 17, 2023
| argument is a literal with a language | ||
| tag. Otherwise, the function returns false. | ||
| </p> | ||
| <p>If the argument is a lteral, the function is |
There was a problem hiding this comment.
Suggested change
| <p>If the argument is a lteral, the function is | |
| <p>If the argument is a literal, the function is |
Comment on lines
+6340
to
+6343
| The function <code>LANGDIR</code> returns the | ||
| language direction of a literal with datatype | ||
| <code>rdf:dirLangString</code>. | ||
| Otherwise, the function return the empty |
There was a problem hiding this comment.
Suggested change
| The function <code>LANGDIR</code> returns the | |
| language direction of a literal with datatype | |
| <code>rdf:dirLangString</code>. | |
| Otherwise, the function return the empty | |
| the function <code>LANGDIR</code> returns the | |
| language direction of the literal with datatype | |
| <code>rdf:dirLangString</code>; | |
| otherwise, the function return the empty |
kasei
reviewed
Aug 1, 2023
| <td><code>false</code></td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>isLANG("abc@en--ltrl"</code></td> |
There was a problem hiding this comment.
Is the second double-quote meant to be before the language tag here?
There was a problem hiding this comment.
Yes. There is also a missing close-paren.
Suggested change
| <td><code>isLANG("abc@en--ltrl"</code></td> | |
| <td><code>isLANG("abc"@en--ltrl)</code></td> |
gkellogg
reviewed
Aug 2, 2023
| <p> | ||
| If the argument is a literal, | ||
| The function <code>LANGDIR</code> returns the | ||
| language direction of a literal with datatype |
There was a problem hiding this comment.
"base direction" is the term from RDF Concepts. Maybe needs a reference?
Suggested change
| language direction of a literal with datatype | |
| base direction of a literal with datatype |
|
This PR is being broken up to make progress easier. #153 includes the grammar changes for initial text direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #112
Function and syntax for working with
rdf:dirLangString.Preview | Diff