From 368661e2d48d00dd76a37a2f2a2dcc71846f78bc Mon Sep 17 00:00:00 2001 From: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com> Date: Fri, 4 Jun 2021 06:40:18 +0530 Subject: [PATCH] fix(core/dfn-panel): don't add title attribute to dfn (#3593) --- src/core/dfn-panel.js | 1 - tests/spec/core/dfn-index-spec.js | 1 - 2 files changed, 2 deletions(-) diff --git a/src/core/dfn-panel.js b/src/core/dfn-panel.js index 6d0254bec5..028d82b993 100644 --- a/src/core/dfn-panel.js +++ b/src/core/dfn-panel.js @@ -28,7 +28,6 @@ export async function run() { // allowing keyboard action as needed. el.tabIndex = 0; el.setAttribute("aria-haspopup", "dialog"); - if (!el.title) el.title = "Show what links to this definition"; } document.body.append(panels); diff --git a/tests/spec/core/dfn-index-spec.js b/tests/spec/core/dfn-index-spec.js index 5180b1b667..dbb1e6a081 100644 --- a/tests/spec/core/dfn-index-spec.js +++ b/tests/spec/core/dfn-index-spec.js @@ -364,7 +364,6 @@ describe("Core — dfn-index", () => { expect(term.tabIndex).toBe(0); expect(term.getAttribute("aria-haspopup")).toBe("dialog"); - expect(term.title).toBe("Show what links to this definition"); expect(term.textContent).toBe("Event interface"); expect(term.id).toBe("index-term-event-interface");